Piotr Monwid-Olechnowicz
Piotr Monwid-Olechnowicz
> @hasparus Any way we can have the default color mode show up as undefined always? That way it would be consistent everywhere and we could just update the snippet...
@ehowey we already have a PR fixing this, so testing, possible fixes and releasing shouldn't take more than a few days
No worries :) Though, I'd advise to go with the workaround.
Hey @ehowey, just FYI. This make take us some more time.
Hey @timfee 👋 Thanks for the issue! You imported `ThemeProvider` from `@emotion/react`, not from `theme-ui`. It's kind of our fault — in the world with auto-imports we should have used...
I wanted to propose a workaround I usually use ```tsx ``` but your solution is pretty awesome. Nice :D
> It looks like Emotion doesn’t directly offer this functionality I just wanted to disagree — there's this one https://emotion.sh/docs/class-names. I think we'd accept a PR for `@theme-ui/classnames` package, but...
![image](https://user-images.githubusercontent.com/15332326/184161952-89af9e16-51af-46aa-a82f-c5be42e18c37.png) Jest doesn't resolve ESM in `--coverage` mode unless we use `v8` coverage provider.
Needs https://github.com/system-ui/theme-ui/pull/2292 to be merged to pass the typecheck step on CI.
@lachlanjc I'd say this is ready for review. The cypress action cache problem can be fixed separately, because it also happens on other branches.