Piotr Monwid-Olechnowicz

Results 141 comments of Piotr Monwid-Olechnowicz

> use the body variables (can be buggy though) True. Breaks during SSR. I like (1) a bit, but I think I'll nead to read https://github.com/system-ui/theme-ui/pull/259 and https://github.com/system-ui/theme-ui/pull/274 again.

> Not exactly sure, since getColor with custom css vars happens after first setting the custom vars to the body I've been thinking that `document` is undefined.

Hey @benface 👋 It would definitely be a great addition. I usually advised people to add stuff to a global CSS file or use a reset, but there are some...

Okay. I'm in need of JSON Schema for the `Theme` (my users are editting their themes from Django Admin). Does anybody have one? :smile:

@lachlanjc I'd keep this open, but the main reason an user would need this package is when you validate Theme UI themes at runtime... so if you build an app...

> Have "@theme-ui/core": "^0.14.5" (not using the complete theme-ui package since the mdx package causes problems with Vite build). `@theme-ui/core` doesn't add any styles to the root. This is implemented...

:rocket: Issue was released in [`v0.15.2`](https://github.com/system-ui/theme-ui/releases/tag/v0.15.2) :rocket:

Good catch @genox. We don't have [`createEmotionServer`](https://github.com/vercel/next.js/blob/canary/examples/with-emotion-vanilla/shared/renderer.js) in any of our examples. @lachlanjc Are you familiar with this problem? (You have a bunch of Next projects, right?)

One problem is that the color modes detection has to be blocking — it's reading from localStorage, and we need it to happen ASAP to avoid color flash. However, I...

Thanks for the PR @Bram-Zijp! Nice catch! @lachlanjc I'll need to take a look at corner cases (how does it look like with SSR? that rerender triggers update) and merge...