Hamish Willee comments

Results 1298 comments of


                                            Hamish Willee

generate WIP warnings on the use of WIP messages in C code

@tridge Thank you. So can't you adjust CI to turn this default off _in CI_ - default on everywhere else? If this is not possible then as above, we'd rather...

generate WIP warnings on the use of WIP messages in C code

OK - thanks. Then let's get it in disabled by default.

generate WIP warnings on the use of WIP messages in C code

So can we merge this please @tridge / @peterbarker ?

Update deprecated MAV_TYPE enum for tailsitter

So it was discussed with @auturgy @DonLakeFlyer @meee1 both in https://github.com/mavlink/mavlink/pull/1818 and also offline. The reasoning for the change is mostly here: https://github.com/mavlink/mavlink/pull/1808#issue-1157921604 > - the description does not precluse...

Mavgen C: Use strncpy instead of memcpy to pack char[n] fields

@peterbarker Can you please look at this. Fixes https://github.com/ArduPilot/pymavlink/issues/725 which has come up a few times as a problem, in particular for new users after they have discovered this the...

Mavgen C: Use strncpy instead of memcpy to pack char[n] fields

So there is no reason this can't go in @peterbarker? Can you merge?

mavlink_msg_xxx_decode by mavgen_c does not handle extensions of message properly

@peterbarker Does this make sense?

mavlink_msg_xxx_decode by mavgen_c does not handle extensions of message properly

Not from me. @peterbarker ?

mavlink_msg_xxx_decode by mavgen_c does not handle extensions of message properly

@JonasVautherin FYI in case this does affect MAVSDK

message CRC checksum is wrong when a mavlink_message_t is converted to a sending buffer

Perhaps better to regenerate this as a PR so that it can be merged if approved? Possibly I'm missing something, but I don't understand why there is an expectation that...