Hamish Willee

Results 1298 comments of Hamish Willee

So quick scan indicates that the same problem probably affects JavaScript at least. I wonder if we might be best off doing a "total" enums calculation in the top level...

@peterbarker Discussed this in the dev call with @auturgy. He raised the point, (which we are already aware of) that the fix to make C work cascades to all generators....

That's great @davidbuzz . I think we could modify this slightly to only impact C and Python now, allowing other runtimes to modify themselves at will. But this is up...

This PR should work properly (now) for anything that builds per-dialect files, and break anything that generates a single flat library (other than Python which I specifically fixed). This will...

Pretty please review @peterbarker

@tstastny FMI "where"/"how" did you run into this? Provided you build the top level dialect and use the top level dialect there are no issues. The only problem is when...

@tstastny So what is supposed to happen is that if you build a top level dialect - say ardupilotmega.xml, you can include ardupilotmega/mavlink.h and get the enums and entities for...

> @hamishwillee correct on all that you say. so the "why" in this case is particularly: > > * PX4 built with a dialect will handle using that dialect on...

@tridge 1. So how do you expect this to be used? I think you are suggesting that a flight stack that wants to prevent WIP messages in their environment would...

> on (2), the problem is we run tests with -Werror, so any warnings would make the test fail Yes, I want to run the tests, watch them fail, and...