Hamish Willee
Hamish Willee
Thanks for tracking this!
@rotu If I knew what I was doing we wouldn't have these problems. I just ran mavgen to the help stage. I'm happy for someone who knows what they are...
@rotu I must have been testing this in a ubuntu VM because as you say, it is not working on Windows - mavgen command is not being found/recognised. > Also,...
@rotu I wasn't joking when I said I don't know what I'm doing. I'm not sure how to progress from here to a console_script that does what is needed. Going...
@julianoes This worked for me on Ubuntu but not on Windows. You should verify that it works for you on the platforms you need. I'd be somewhat OK with including...
I can't remember. I''ll have to try this again in two weeks.
@olliw42 I basically just hooked into your [expand_includes()](https://github.com/ArduPilot/pymavlink/pull/544/files#diff-771a8f0d763a6e2675773e6358708f7791964f8ccd4fe869056361d674b78ba2R255) then call merge on every include. At the end clean up all the enums to add the end value. I'm fine with...
You'll have the definitions in every file "above" where the MAV_CMD was defined in the dialect chain. But they should be guarded so that they are imported only once, in...
This is Python right? I ask because I tested on C. Of course Python has to work too and I will look at this.
@peterbarker Fixed for python. Identical-ish output now before and after: [py_compared.zip](https://github.com/ArduPilot/pymavlink/files/6699140/py_compared.zip) In summary, the original parser was flawed because it removed any duplicated enums from the _nested_ dialect objects. The...