Hamish Willee comments

Results 1298 comments of


                                            Hamish Willee

generate WIP warnings on the use of WIP messages in C code

When we use similar approach for deprecated tag, wouldn't it be better if that was "default on"?

generate WIP warnings on the use of WIP messages in C code

@peterbarker @auturgy Should this be merged? I don't love the implementation in that the whole idea was that WIP stuff should not be used in production. tridge has his reasons,...

generate WIP warnings on the use of WIP messages in C code

> Ideally we’d build with WIP by default in Master/Dev branches but not in production/release branches. @auturgy Yes, though I guess that would have its own challenges when you cut...

generate WIP warnings on the use of WIP messages in C code

@peterbarker FWIW my leaning is not to remove WIP stuff from builds. Had we decided to build without the WIP stuff at the beginning it would have been good/ok. But...

generate WIP warnings on the use of WIP messages in C code

As discussed in dev call and https://github.com/mavlink/mavlink/pull/1924#issuecomment-1341651246 Our preference is that mavgen builds without WIP entities by default - I am assuming enum values will always be "at the end"...

generate WIP warnings on the use of WIP messages in C code

@peterbarker Did you have a chance to discuss this in call?

generate WIP warnings on the use of WIP messages in C code

@peterbarker We closed #1924 in December 2022 in favour of this PR added in 2018 on your suggestion. You're right - this is a better technical solution than constructing XML...

generate WIP warnings on the use of WIP messages in C code

Thanks very much @peterbarker . What needs to happen to get this in? Do you need more testing, or something else? I can help.

generate WIP warnings on the use of WIP messages in C code

Shall we wait another 5 years?

generate WIP warnings on the use of WIP messages in C code

FYI @auturgy - this is the one discussed in the call.