Peter Hunt

Results 616 comments of Peter Hunt

LGTM, though we'll need https://github.com/cri-o/cri-o/pull/3911 before anything else can get in

> So on a k8s cluster with docker, docker doesn't send back any intermediate images to k8s. When k8s gcs the final image that has intermediate images associated with it,...

oop, lint failure, gofumpt strikes again :upside_down_face:

@vrothberg do you think we'd want something similar to https://github.com/containers/podman/pull/7215 here?

@wgahnagl can you rebase this?

I think this update is a great start, and the correct direction. I think it should be a goal to drop more of the args here rather than passing them...

> > I think it should be a goal to drop more of the args here rather than passing them into Annotations() > > I agree. Anything more than 3-5...

see my comment https://github.com/cri-o/cri-o/issues/4807#issuecomment-826902914 I am not sure yet, but I may be a NACK on this one

/approve LGTM I believe a rebase will fix the tests for you