Peter Hunt

Results 616 comments of Peter Hunt

no problem! 1.27 was a ambitious milestone to aim for anyway :)

thanks! you've got some markdown lint failures

one note, otherwise LGTM. good idea here @bitoku

I have attempted to add systemd to the nix builds in https://github.com/containers/conmon/pull/431 It looks like the upstream debian packages add systemd libraries for the builds, so we should be good...

we have definitely hit issues in the past because of us holding the lock during stop. However, I think preventing other calls to the oci runtime makes sense to prevent...

yeah so theoretically we could not lock during a stop, and instead just during the runtime calls. I think there is the possibility of getting into a weird state in...

I would personally treat it kind of like a feature and be very careful about backporting it if we do take the change. I wouldn't want to introduce instability in...

I would recommend you begin by reproducing the issue. Then, you can reconfigure the locking scheme in the Stop functions in `internal/oci/runtime_oci.go` to fix the issue. Since you've reproduced, you...