Peter Hunt
Peter Hunt
/hold actually, ci is broken at the moment, let's wait till it's ready
/ok-to-test
huzzah! can you sign off the PR with `git commit --amend -s` and `git push -f origin add-all-flag`? some tests will fail and it's not the fault of this PR
I've been stewing on this PR, and am starting to think the approach should change. since docker and containerd hide these layers by default, it really seems like we should...
``` Jun 23 16:51:26 ip-172-18-3-1.ec2.internal crio[25323]: goroutine 193467 [running]: Jun 23 16:51:26 ip-172-18-3-1.ec2.internal crio[25323]: panic(0x1d8a300, 0xc000cb1d00) Jun 23 16:51:26 ip-172-18-3-1.ec2.internal crio[25323]: /usr/local/go/src/runtime/panic.go:1060 +0x420 fp=0xc0005d3570 sp=0xc0005d34c8 pc=0x43c880 Jun 23 16:51:26 ip-172-18-3-1.ec2.internal...
``` time="2020-06-25T15:53:14Z" level=error msg="error copying docker://quay.io/crio/redis:alpine to dir:/go/src/github.com/cri-o/cri-o/.artifacts/redis-image: Error reading blob sha256:aae70a2e60279ffae89150a59b81fe10d1d81f341ef6f31b9714ea6cc3418577: Get \"https://quayio-production-s3.s3.amazonaws.com/sha256/aa/aae70a2e60279ffae89150a59b81fe10d1d81f341ef6f31b9714ea6cc3418577?Signature=vvFm5nT9UpwrBh19%2F5Q7TvYJF1s%3D&Expires=1593100984&AWSAccessKeyId=AKIAI5LUAQGPZRPNKSJA\": net/http: TLS handshake timeout" ``` and provisioning flakes /retest
LGTM, thanks for sticking with this :tada: @umohnani8 @saschagrunert @mrunalp PTAL