Peter Hunt

Red Hat

Results 616 comments of


Peter Hunt

server: allow for kubelet to specify -1 for swap

/cherry-pick release-1.24

build(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0

/ok-to-test /approve /lgtm

build(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0

/lgtm cancel without https://github.com/cri-o/cri-o/pull/6132 this will fail a bunch

build(deps): bump github.com/prometheus/client_golang from 1.12.2 to 1.13.0

@dependabot rebase

Allow runtimes to be added and default runtime to be modified on config reload

/ok-to-test thanks @elezar ! I have a couple of notes, but this is definitely in the right direction

Allow runtimes to be added and default runtime to be modified on config reload

would you still consider this to be a draft @elezar ?

Allow runtimes to be added and default runtime to be modified on config reload

@elezar is this ready? /retest

Allow runtimes to be added and default runtime to be modified on config reload

/approve LGTM, thanks @elezar ! @cri-o/cri-o-maintainers PTAL

Multi storage support and selection using the runtime class

/ok-to-test thanks @alicefr !

Multi storage support and selection using the runtime class

couple of nits, sorry I forgot to review yesterday! I find myself wondering if processesing the annotaiton on the pod level is the best route. this seems like something an...