Hadley Wickham
Hadley Wickham
@cbielow yes, that's the output. But what's the input that causes it?
Thank you!
This looks like a bug in `warn_missing_s3_exports()`, which happens, I think, because `all.equal` was an S3 method, but `setMethod()` has turned it into an S4 generic. This is clearly a...
Realised we could use the existing `env_names()` for this.
Reprex: ``` r library(dbplyr) library(dplyr, warn.conflicts = FALSE) db group_by(user_id) %>% window_order(dates) %>% window_frame(-Inf, -1) %>% mutate(list_amount = sql("collect_list(amount)")) %>% sql_render() #> SELECT `dbplyr_IFzQhHZAlG`.*, collect_list(amount) AS `list_amount` #> FROM `dbplyr_IFzQhHZAlG`...
Looking in more depth, I don't think we can do this directly for `sql()` but I think we could introduce a new `sql_win()` helper that would have any windowing functions...
Probably the same as #2877
Hmmm, weird. Even simpler reprex: ```R test_that("should intentionally fail", { expect_no_error(foo()) }) ````
Hmmmmm, I think one principle of waldo is that if `compare(x, y)` reports differences then so should `compare(y, x)`. So that suggests we should maybe deliberately deviate from `all.equal()`. But...
Moving to pkgdown since that's where the fix needs to be. It is very confusing that there's no scrollbar here.