Hadley Wickham
Hadley Wickham
I've forwarded this to @jeroen to take a look at, and since it doesn't appear to be a httr2 issue, I'm going to remove this from the milestone.
And closing here since it's now tracked in curl.
This is no longer a problem in curl, but it looks like we still have some work to do in httr2: ``` r library(httr2) url
Fixing the memory allocations is going to require a couple of hours of work. Will first need to create a ring buffer implementation so that we can retrieve and use...
With ~4 hours work: ``` expression min median `itr/sec` mem_alloc 1 stream_data(req) 6.83s 6.83s 0.147 43.03MB 2 stream_data_raw(req) 5.38s 5.38s 0.186 1.28MB ``` I thought it would be a bigger...
@jeroen I think there's still work to do in httr2, since we also do buffering that seems to be creating a bunch of copies.
Are you sure you want the default values to be class objects? That seems a bit surprising to me.
Yeah, I'd definitely suggest an alternative approach because inlining the class definitions into the function defaults is not a good idea, IMO.
@mjskay I forgot about that, thanks!
Would you mind being a bit more explicit about what the problem is?