Hadley Wickham
Hadley Wickham
Plan co-developed with claude: ## Goal Implement a `sql_dialect()` system to reduce method duplication across database backends by: 1. Creating a dialect object that acts as an (optional) intermediary in...
* `supports_table_alias_with_as` and `supports_window_clause` are simple generics which aren't used by many packages, so we can change without breaking backward compatibility. I originally had the same thought of you as...
@nealrichardson hmmmm, this will be a step in that direction, but I don't know if it'll be enough. DBI is pretty tightly woven throughout dbplyr and I probably don't have...
@rgriffier @admivsn @ablack3 any chance any of you can test this with a real Oracle?
Not clear to me how we could trigger conflicted to look for conflicts in this context — it's registers conflicts when you run `library()` or similar. When would we trigger...
FYI I'm scheduling the testthat release for Nov 10.
I think the place to start would be to prototype a custom `compare` function that you can pass to `expect_snapshot_file()`. If that's sufficient, we can figure out how to include...
IMO this is a vdiffr feature, not a testthat feature.
I'm pretty sure this only needs vdiffr, since vdiffr can pass `compare = compare_file_text_svg` to `expect_snapshot_file()`. So I'm going to move this issue to vdiffr.
As this rolls out across more packages, we'll do more to promote it, so hopefully folks start to internalise that this sort of observability is available in all the packages...