Niklas Haas

Results 354 comments of Niklas Haas

It seems like there might be a mathematical error in our calculation of the desaturation (in `--tone-mapping-mode=luma/hybrid`). I'll look into it further in a bit.

https://code.videolan.org/videolan/libplacebo/-/merge_requests/329 this fixes the bug in the desaturation logic, to make it pick the proper desaturation factor from BT.2446a. This is not quite extreme as `--saturation=-25`, but overall saturation should...

Original (bugged, before the patch): ![mpv-shot0001](https://user-images.githubusercontent.com/1149047/202820332-5a04d2bf-7b44-4255-97d7-d193c0aa5c23.jpg) Original with `--target-peak=88`: ![mpv-shot0002](https://user-images.githubusercontent.com/1149047/202820354-38cc077e-7cf5-40c5-ae8a-2f5be80ff8fe.jpg) Original with `--target-peak=88 --saturation=-25`: ![mpv-shot0003](https://user-images.githubusercontent.com/1149047/202820368-df5bf326-a78d-46f7-97ef-a65c838e2412.jpg) Fixed with `--target-peak=88`: ![mpv-shot0004](https://user-images.githubusercontent.com/1149047/202820382-67f310cd-adfa-432f-8626-42723b69ac4c.jpg) Fixed with no settings: (default peak) ![mpv-shot0005](https://user-images.githubusercontent.com/1149047/202820405-90bb657c-5e13-42f6-9774-e1ce32715507.jpg) You can clearly tell...

Oh, the new logic has a fatal flaw for more extreme tone-mapping ratios. A better function is needed.

Maybe we should just expose the peak-dependent desaturation factor as a user control.

Doesn't seem like there's an obvious issue in the metadata: ``` [vf] [out] 3840x2160 yuv420p10 bt.2020-ncl/bt.2020/pq/limited/display SP=4.926108 CL=uhd [vf] [out] 3840x2160 p010 bt.2020-ncl/bt.2020/pq/limited/display SP=4.926108 CL=uhd ``` It could be the...

Old issue, and no longer as pressing since `--gamut-mode=clip` is now the default behavior, but the likely culprit here is that `d3d11va` hwdec does not forward all HDR mastering metadata,...

> Does target-colorspace-hint affect SDR contents in Gnome Desktop Environment? I have no clue. But I strongly doubt it. > The color looks so strange when my ICC profile is...

Isn't this literally what `--hdr-compute-peak` does? Incidentally, in the past, we used to also measure the frame average brightness and darken the scene even further if needed, but that functionality...

> I don't want to be impolite, but are there any news regarding tone mapping and these problematic scenes? :-) Nope :( Better tone-mapping is unfortunately not currently at the...