mpv icon indicating copy to clipboard operation
mpv copied to clipboard

d3d11va does not forward HDR metadata to VO

Open FoLLgoTT opened this issue 3 years ago • 3 comments

Important Information

With gpu-next and hwdec=d3d11va-copy or dxva2-copy the image is significantly darker on HDR content.

Software decoding: software_decoding_klein

Hardware decoding: d3d11va-copy_klein

Expected behavior

Same brightness.

Actual behavior

Image is darker.

Log file

softwaredecoding.txt d3d11va-copy.txt

FoLLgoTT avatar Feb 06 '22 07:02 FoLLgoTT

Doesn't seem like there's an obvious issue in the metadata:

[vf] [out] 3840x2160 yuv420p10 bt.2020-ncl/bt.2020/pq/limited/display SP=4.926108 CL=uhd
[vf] [out] 3840x2160 p010 bt.2020-ncl/bt.2020/pq/limited/display SP=4.926108 CL=uhd

It could be the mastering colorspace primaries. Just to confirm, does --gamut-mode=clip make the difference go away?

haasn avatar Feb 06 '22 09:02 haasn

It could be the mastering colorspace primaries. Just to confirm, does --gamut-mode=clip make the difference go away?

Yes, with clip the problem completely goes away.

FoLLgoTT avatar Feb 06 '22 09:02 FoLLgoTT

Old issue, and no longer as pressing since --gamut-mode=clip is now the default behavior, but the likely culprit here is that d3d11va hwdec does not forward all HDR mastering metadata, by the sound of it.

haasn avatar Sep 27 '22 23:09 haasn

@FoLLgoTT Could you test with the latest version? There were fixes recently in this area and to my knowledge all metadata is passed correctly now with -copy hwdec.

kasper93 avatar Mar 10 '23 03:03 kasper93

@kasper93 I don't seen any difference anymore. Thank you! :-)

FoLLgoTT avatar Mar 10 '23 06:03 FoLLgoTT

Seems like this was fixed? Closing.

Dudemanguy avatar Aug 09 '23 15:08 Dudemanguy