Heberto Mayorquin

icon indicating a website link https://h-mayorquin.github.io/ icon indicating an email [email protected]

icon location Moving bits around before the bots take over the craft. Contributing to the creation of open source infrastructure for neuroscience at @catalystneuro.

Results 511 comments of Heberto Mayorquin

[Feature]: Make `get_data_in_units` not load entire array into memory

Interesting idea. I am personally curios about how the implementation of WrappedArray would look like. Another alternative is to pass a slice as an argument to `get_data_in_units` but that way...

Best practices when reading zarr arrays in languages with limited support for data types.

Maybe now it could be implemented now? https://caniuse.com/?search=BigInt64Array

Try "Handle motion/drift" documentation as a sphinx gallery

@JoeZiminski it is in my to-do list to review this. Just a ping

Handle ms_before and ms_after difference between waveforms and template extensions

All right. Where should this behavior be written?

Handle ms_before and ms_after difference between waveforms and template extensions

Thanks @alejoe91

Remove unused extractor attribute `extractor_name`

Requires https://github.com/SpikeInterface/spikeinterface/pull/2876 for some reason : O

SortingAnalyzer.get_extension() should fail when the extension does not exist

Yeah, that internal code should be refactored I think. Public API should not be constrained to internal convenience.

SortingAnalyzer.get_extension() should fail when the extension does not exist

My only strong preference is that the one that is available to users behaves like a normal dictionary without magic. Implicit behavior is always confusing. Right now we have three...

SortingAnalyzer.get_extension() should fail when the extension does not exist

Thanks for the explanation Sam. Our of curiosity, the return None property, is just for syntactic suggar, right? The convenience that you point above is the one that @zm711 pointed...

SortingAnalyzer.get_extension() should fail when the extension does not exist

Mmm not sure how to move forward. I don't like @samuelgarcia magic and I think that the current state of affairs is very confusing for end users at the cost...