Heberto Mayorquin

I will keep this open until Sam updates the issue just as a todo.

This was solved by https://github.com/SpikeInterface/spikeinterface/pull/2891

I think this happened a month ago: https://github.com/SpikeInterface/spikeinterface/actions/workflows/test_imports.yml?page=15&query= I am suspicious of this one (sadly)!: https://github.com/SpikeInterface/spikeinterface/actions/runs/8649714706

Yeah, that's my guess, but I remember being concerned about it and finding that it was not the case. We have been discussing how to wrap numba functions so they...

Some of them are wrapped: https://github.com/h-mayorquin/spikeinterface/blob/0942fda7ce60c644a397c8d86c091eba6f07706d/src/spikeinterface/comparison/comparisontools.py#L110-L207 Others are not: https://github.com/h-mayorquin/spikeinterface/blob/0942fda7ce60c644a397c8d86c091eba6f07706d/src/spikeinterface/postprocessing/correlograms.py#L317-L392 I am pro-wrapping. @samuelgarcia and @DradeAW were against it (on aesthethical grounds I believe). But I have to confess that...

Thanks a lot for organizing this. Yes, I don't know how clear I was in the other PR but I believe this should be tested and fixed. What I was...

I was getting the error on windows while these tests with pytest: #2170 Linking here for tracking.

I think there are some hanging fruit that you pointed out. That's great! We should make a TODO list : )

Great! Thanks for the actionable plan.

Numpy 1.20 has been deprecated for a year: https://numpy.org/neps/nep-0029-deprecation_policy.html Maybe something to discuss at neo. Any reason you guys are testing for that?