spikeinterface icon indicating copy to clipboard operation
spikeinterface copied to clipboard

Handle ms_before and ms_after difference between waveforms and template extensions

Open h-mayorquin opened this issue 1 year ago • 3 comments

They might be different, we can either raise an error like here or change to a warning and priviledge the ones of the waveform as we are doing right now.

What do you guys think?

h-mayorquin avatar May 17 '24 20:05 h-mayorquin

@h-mayorquin after discussing with Sam, we think it's ok that waveforms control the ms_before/after, let's just be clearer with this in the docs without too many warnings

alejoe91 avatar Jul 03 '24 08:07 alejoe91

All right. Where should this behavior be written?

h-mayorquin avatar Jul 03 '24 12:07 h-mayorquin

@h-mayorquin adding a comment here in the Templates section should be enough

alejoe91 avatar Sep 25 '24 08:09 alejoe91

Made a PR with a doc clarification on the inheritance of ms_before/after. Let's close this one https://github.com/SpikeInterface/spikeinterface/pull/3663

alejoe91 avatar Feb 03 '25 09:02 alejoe91

Thanks @alejoe91

h-mayorquin avatar Feb 04 '25 22:02 h-mayorquin