Alexandre Bury

icon indicating a website link https://www.linkedin.com/in/alexandre-bury/ icon indicating an email [email protected]

icon company @argoai icon location Pittsburgh, PA, USA icon location "Such a wasted opportunity for overkill."

Results 401 comments of Alexandre Bury

`zstd_safe::DCtx::decompress_stream` may result in UB

Ouch, indeed. I think we should add an internal flag that gets set on an error and reset on initialization/reset, and check that flag before running `decompressStream`. Technically not zero-cost,...

zstd-rs is slower than `tar -xf` for `.tar.zst`

Hi, and thanks for the report! In general, there _may_ be overheads in the rust wrapper. Rust's `Read`/`Write` abstractions may involve some extra memcopies depending on the use-case. I'm open...

[Fixes #763] Introduced labelled checkboxes

Thanks for the work! I merged main into this branch (solving minor conflicts that arose when views became `Send`), and it should now be closer to ready. One remark: the...

[Fixes #763] Introduced labelled checkboxes

Thanks again for the work!

impl `std::error::Error` for `cursive::theme::Error`

Hi! No reason, just didn't think about it. Would definitely appreciate a PR!

[BUG] Incompatible with bp3d crates

Hi, and thanks for the report! The logger backend is not attached by default. It's only attached in `cursive::logger::init()` (which itself is not called by any other code in `cursive`)....

[BUG] ANSI parsing not complete

Thanks for the report! We're currently using [`ansi-parser`](https://crates.io/crates/ansi-parser) to parse that (https://gitlab.com/davidbittner/ansi-parser). It looks like it's indeed not properly parsing some of the escapes output by `delta`. Looks like a...

Properly clear terminal on Cursive::clear()

Hi, and thanks for the work! I'm just concerned that this would cause excessive I/O in most cases. Maybe we need a different function specifically for when another application may...

[FEATURE] Images for the examples would be extremely helpful

This is a very good point! Having a more systematic approach to screenshots (or even small videos) would be great.

[BUG] ScrollView.show_scrollbars(false) only hides thumb, not entire bar

Hi, and thanks for the report! Indeed, there was an error in the layout logic with hidden scrollbars. It should be fixed on the latest commit.