Alexandre Bury
Alexandre Bury
Added a `no_wasm_shim` feature to `zstd-sys`. ``` $ export CC="${WASI_SDK_PATH}/bin/clang --sysroot=${WASI_SDK_PATH}/share/wasi-sysroot" $ # Building without the shims. There are some warnings re: the usage of clock(), which can be ignored...
(Disclaimer: I have zero experience building stuff for wasm.) There is a `it_work` example in `zstd_sys`. I can try building it with `cargo wasi build` without any feature (so it...
Thanks for the PR! A few questions: * Since this is all internal API, why separate `MaybeOwned` and `MaybeOwnedInner` types? * Why store a `* mut ()` + `PhantomData` rather...
Thanks for the work! Let's start with that, we'll see later if/how we could allow both referencing a dict and a context.
CI failures looks weird - maybe you need to rebase?
Ended up testing and merging the PR locally. Thanks for the work!
Hmm not sure what's causing it. Does this only happen in CI? Can you reproduce this locally? Are you using any features on `zstd-sys`? (In particular `pkg-config`?) Does it use...
I think I found the issue. We were using `-flto=thin` which doesn't exist on GCC (but somehow still goes through `add_flag_if_supported`). It looks like cross is using GCC, which exposes...
It should not need nightly, but it's possible the rustc version is now 1.64.
Ok, I'll remove this `-flto=thin` until we find a more robust solution to enable only if it doesn't break stuff. I also updated the bindgen arguments to target 1.47 (instead...