Alexandre Bury

icon indicating a website link https://www.linkedin.com/in/alexandre-bury/ icon indicating an email [email protected]

icon company @argoai icon location Pittsburgh, PA, USA icon location "Such a wasted opportunity for overkill."

Results 401 comments of Alexandre Bury

The trait `Sync` is not implemented for `NonNull<ZSTD_CCtx_s>`

A zstd context is `Send` (you can move it across threads), but it is not `Sync` (you should not query it across threads). It was initially set in https://github.com/gyscos/zstd-rs/pull/32. One...

Can we control the stack size of zstd?

Hi, Not that I know of. This might be a question for https://github.com/facebook/zstd. It does sound surprising though. I wouldn't expect the zstd lib to have a stack usage that...

zstd-sys cannot compiled at WSL1

Might be related to the `parallel` feature we enable in `cc`?

bit-identical output to zstd command line tool

Hi, and thanks for the report! I'm not entirely sure how to get bit-identical output with the CLI. First, you will of course need to ensure you are using the...

Creating self-contained compressed sequences.

Note that most zst-compressed files are going to store a single frame (for optimal compression ratio). If you want to concatenate several frames and need random access to them, you...

Ensure buffers are flushed to avoid decompression stream underread

Hi, and thanks for the PR! The comment from the zstd lib refers to internal buffers that need to be flushed: when no more input is required, but more output...

Endless loop on incomplete frame error

Ah I finally understood what happens: when it reaches the unexpected EOF, the `Decoder` returns an error. If you call it again, it will keep returning this same error. The...

zstd::bulk::decompress: says "less than" instead of "less or equal"

Indeed, thanks for the report! Should now be fixed.

zstd::bulk::decompress: says "less than" instead of "less or equal"

Oh right I only updated `Decompressor::decompress()`. Fixing that now.

Add some option to disable the wasm-shim

Hi, and thanks for the report! I can look into adding a `no-wasm-shim` feature, but I'm curious why it's not working for you. `rust_zstd_wasm_shim_malloc` should be provided by the `zstd-sys`...