cursive icon indicating copy to clipboard operation
cursive copied to clipboard

[Fixes #763] Introduced labelled checkboxes

Open michalfita opened this issue 2 years ago • 2 comments

Purpose

To address #763 and improve overall UX of using Checkbox in the application.

Scope

  • The implementation
  • Examples

To do

  • [x] Add label for showing selection over whole Checkbox
  • [x] Create grouping for MultiChoice to make application logic easier
  • [ ] Example combining Checkbox and RadioButton

Notes

Commits bring changes incrementally, so I suggest reviewing them one by one and consider rejections based on changes in them as maybe not all PR would need to be rejected at once.

For now I do draft for first impression where I'm heading. I'm trying to not break original API, however, some alignment with RadioButton in future would do good.

michalfita avatar Oct 25 '23 11:10 michalfita

Thanks for the work!

I merged main into this branch (solving minor conflicts that arose when views became Send), and it should now be closer to ready.

One remark: the example now shows 2 ways to make groups of checkboxes: the "manual way" (for toppings) and the "managed way" (for extras). To keep the example simple, I think we can get rid of the manual way and only show how to use the multichoice group.

Instead, we could include a couple of "non-grouped" checkboxes, to show that it's still an option for single options. Or not, since that's already covered in the "list_view" example. In that case, I would rename the checkbox example to checkbox_group or multichoice_group.

gyscos avatar May 31 '24 14:05 gyscos

@gyscos Oh man, it's been a while since I've been on this... Finding time to go back to this may be close to impossible in a next few weeks.

michalfita avatar May 31 '24 22:05 michalfita

@gyscos I forgot about this PR until I went back to Cursive for something I'd like to implement. I've aligned the code with main again and simplified the example a little.

michalfita avatar Oct 10 '25 17:10 michalfita

Also, are the two examples different?

Now, examples are even more different. I think they'd work well for someone trying to consider various options how to use checkboxes.

michalfita avatar Oct 16 '25 10:10 michalfita

Thanks again for the work!

gyscos avatar Oct 17 '25 17:10 gyscos