Grant Willcox
Grant Willcox
Update pre-commit-hook.rb so that we run msftidy_docs.rb on PR submissions that modify documentation
Hmm alright I'd want to check what effort would be required to change these files, but I'm happy to hold off on this PR until those changes are implemented. I'd...
@hamax97 Edited one part of your overview (very nicely written btw, thanks for putting all this info into the description it really helps a lot!) since you were disabling the...
Overall looks good minus the one comment I left above. Will do some testing so long since that comment should not affect code since its just a doc file.
Before: ``` msf6 exploit(multi/handler) > [*] Sending stage (1017704 bytes) to 192.168.153.128 [*] Meterpreter session 1 opened (192.168.153.128:4444 -> 192.168.153.128:34120) at 2023-01-31 10:25:24 -0600 msf6 exploit(multi/handler) > sessions -i 1...
After, showing this issue is now fixed: ``` msf6 exploit(multi/handler) > sessions -i 1 [*] Starting interaction with 1... meterpreter > run post/multi/general/execute COMMAND='date --date=2023-01-01 --iso-8601=ns' [*] Executing date --date=2023-01-01...
Thanks for this PR @hamax97 much appreciate you fixing this!
# Release Notes A bug has been fixed whereby issuing a command line argument that contained nested equals signs would not be parsed correctly, and would instead be treated as...
Unassigning, user does not seem to have forked the Metasploit Framework repo and so I think this task may have been abandoned.
Resolved with https://github.com/rapid7/metasploit-framework/pull/17663 which has now been landed.
For the record I'm happy to work on fixing this up but would like some official confirmation from Spencer or Alan on this PR as to what our desired approach...