Grant Willcox

Results 252 comments of Grant Willcox
trafficstars

Will push up the change now. Can also confirm there are no extra queries after we cache the results.

> Thanks for fixing that, i'm a bit confused as to what was changed as github did something funky to the git history. Ah I rebased this against latest updates...

@sempervictus Sounds good, feel free to go ahead with that and I can do a PR instead.

PR raised at https://github.com/sempervictus/metasploit-framework/pull/35 to implement the fix.

After discussing this with Spencer I think this is a nice addition however given the existing DNS base of our code is iffy from what I've been told, this may...

@sempervictus I think @smcintyre-r7 and I were discussing moving things down to just one DNS library and that is an interest of ours though the main concern would be potential...

Should probably take a look at https://github.com/rapid7/metasploit-framework/issues/9209 and see if we can fix all the issues mentioned there. I know a few were fixed earlier but there are a few...

Marking delayed until the comments mentioned above are addressed.

Fair point, and yeah I agree on second review that this should have just been landed, thanks for calling me out on that, I'll keep that in mind for next...

There is a lack of information here. Specifically you haven't told us what OS you are using and what steps you have taken and their order, as well as what...