Grant Willcox
Grant Willcox
Going to go ahead and close this since the original issue reported here should now be fixed with the changes above, which I went ahead and tested as part of...
There is a workaround for this for the time being but going to see if I can dig into this a bit deeper. ``` msf6 post(windows/gather/memory_dump) > loot --type enum_patches...
Might also need to update the `-d` option as well since that seems to be either broken or I'm using it completely wrong.
Alright so best I can tell the reason this is failing is because the `loots` method inside of `lib/msf/core/db_manager/loot.rb` never actually uses any of the tag information for its searches...
Seems to still be an issue, nearly 10 years later: ``` msf6 exploit(windows/smb/psexec) > show options Module options (exploit/windows/smb/psexec): Name Current Setting Required Description ---- --------------- -------- ----------- RHOSTS 192.168.153.132...
Note there is a possibility that `get_host_tags` and `delete_host_tag` also need to be updated here as well.
Yeah looks like `delete_host_tag` is completely broken when doing `hosts -T mytag`.
Okay so fixed the `delete_host_tag` when supplying a range however when doing `hosts -T mytag` it seems like the code at `lib/metasploit/framework/data_service/proxy/host_data_proxy` is calling `add_host_id_to_opts` inside its `delete_host_tag` implementation which...
Update `get_host_tags` actually works fine cause the `host_id` variable is properly updated in that part of the code, so looks like its just the issue I mentioned above that still...
*phew*....Alright all the above issues should now be fixed 👍