metasploit-framework
metasploit-framework copied to clipboard
rapid7
Fix import-dev-keys.sh
The committer keys URL changed, and the exceptions are wack. Should probably be updated to include GitHub keys (e.g., https://github.com/smcintyre-r7.gpg). Feel free to modify this PR as you see fit!
I'm afraid I can't work on this anymore.
Feel free to modify this PR as you see fit!
Food for thought.
https://github.blog/changelog/2022-08-23-ssh-commit-verification-now-supported/
For the record I'm happy to work on fixing this up but would like some official confirmation from Spencer or Alan on this PR as to what our desired approach is before we go ahead with fixing this, given its nature and the fact that this will likely end up breaking some backend components if the wrong approach is taken.
After speaking to Alan I think the best option here is to just replace the script with some output that warns the user this isn't being used anymore. We can monitor for any side effects or oddities and then go from there, and this will also make reverting things easier down the line should this be needed.
Looks good to me
I'd rather we remove the entire script
Also works for me 👍
Looks like the script was originally added to supplement a workflow that we don't use these days ae73cd3
~~As a side note we may still be referring to this script in our Wiki documentation so we should probably update that as well at some point.~~ Edit: This was fixed as part of this update.
Okay made updates, @adfoster-r7 any way you can do a double check on what I changed here just before we go ahead and land this in to make sure there aren't any concerns r.e what I changed?
Thanks! Glad this is done. Just to note, since my initial commit was blown away in the force push, if this gets reverted in the future, the script will break again.