guscarreon

Results 11 comments of guscarreon

Just like it was done in the `AgmaLogger`'s implementation of `Shutdown()`, can we please add `glog.Infof` entries in the `FileLogger` and `PubstackModule` implementations? ``` 88 // Shutdown the logger 89...

Hey @scr-oath. Just a friendly ping, on the status of this PR. Are you still working on this? From the comments above I see that rolling back to Go 1.20...

Hi @zhongshixi. I believe a recent merge is provoking conflicts between your PR and master. Can you please resolve?

In the docs PR you share above, I see you created files for aliases `1accord` and `easybid`. Back in this PR, you specify those aliases in files `static/bidder-info/1accord.yaml` and `static/bidder-info/easybid.yaml`....

@gchicoye there seem to be some validation github action checks that are failing because of formatting. This seems to be the problem: ![image](https://github.com/user-attachments/assets/e2da3894-5590-4469-9169-e6de3f534bf3) Can you please correct by doing locally:...

> Hi @guscarreon , @pm-nikhil-vaidya , what is the status here? Can we move forward? Thanks :) Hi @gchicoye I'm waiting for @pm-nikhil-vaidya to review your update so I can...

Taking a look. I'm sorry I couldn't come back to it in such a long time

In your docs PR [AdMatic: documenting admaticde and netaddiction alias #5639](https://github.com/prebid/prebid.github.io/pull/5639), `monetixads.yaml` and `pixad.yaml` don't seem to have been included. Can we open a separate docs PR to document them?...

@cto-clydo, the most recent commit to your PR is failing one of our validation scripts. It has to do with the format of the `adapters/clydo/clydo.go` file. From your local folder,...