New adapter: Nexx360
https://github.com/prebid/prebid.github.io/pull/5974
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, a6a8b9dc2bd735fbe1f9b884010e637180c3d7b2
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:57: makeImps 89.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:109: MakeRequests 90.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:154: makeReqExt 80.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:177: MakeBids 96.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:227: getBidType 91.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:249: Builder 100.0%
total: (statements) 90.7%
In the docs PR you share above, I see you created files for aliases 1accord and easybid. Back in this PR, you specify those aliases in files static/bidder-info/1accord.yaml and static/bidder-info/easybid.yaml. However, I see a third document in the docs PR: dev-docs/bidders/prismassp.md. Is prismassp supposed to be another Nexx360 alias? Are you forgetting to include a third alias in this PR in a static/bidder-info/prismassp.yaml file?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, ddf884077c7158ce3d3fbc9fc1872c5693279fc7
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:58: makeImps 90.9%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:101: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:154: makeReqExt 80.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:177: MakeBids 96.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:227: getBidType 91.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:249: Builder 100.0%
total: (statements) 90.6%
In the docs PR you share above, I see you created files for aliases
1accordandeasybid. Back in this PR, you specify those aliases in filesstatic/bidder-info/1accord.yamlandstatic/bidder-info/easybid.yaml. However, I see a third document in the docs PR:dev-docs/bidders/prismassp.md. Isprismasspsupposed to be another Nexx360 alias? Are you forgetting to include a third alias in this PR in astatic/bidder-info/prismassp.yamlfile?
Fixed
@gchicoye there seem to be some validation github action checks that are failing because of formatting. This seems to be the problem:
Can you please correct by doing locally:
$ gofmt -l -w adapters/nexx360 openrtb_ext
adapters/nexx360/nexx360.go
openrtb_ext/bidders.go
openrtb_ext/imp_nexx360.go
And commiting those changes again please?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, d383c49e2325dbdd97932968fcfb023288939f77
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:57: makeImps 90.9%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:98: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:149: makeReqExt 80.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:172: MakeBids 96.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:222: getBidType 91.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:244: Builder 100.0%
total: (statements) 90.6%
gofmt -l -w adapters/nexx360 openrtb_ext
Done! Thanks for that!
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 70c6882f3225aceb4730d09f0e0abadf368ecc7a
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:53: processImps 90.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:93: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:103: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:157: MakeBids 96.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:211: getBidType 91.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:233: Builder 100.0%
total: (statements) 92.3%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 5a6f521f425be240e7843d654039fc0bddbcf908
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:53: processImps 90.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:93: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:103: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:155: MakeBids 96.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:209: getBidType 91.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:231: Builder 100.0%
total: (statements) 92.3%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, dfd21d738024509b3f33c8db98401f40b95060cf
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:53: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:62: processImps 90.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:102: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:112: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:164: MakeBids 96.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:218: getBidType 91.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:240: Builder 100.0%
total: (statements) 91.5%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 54baa41efe4bbdbea0c6acb6482178c54db02b89
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:50: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:57: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:66: processImps 88.9%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:109: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:119: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:171: MakeBids 95.8%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:218: getBidType 91.7%
total: (statements) 90.7%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 9959335771367e4ad6ff9f3c31d7f36e57090f7e
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:48: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:55: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:64: processImps 88.9%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:107: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:117: MakeRequests 88.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:169: MakeBids 95.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:214: getBidType 91.7%
total: (statements) 90.6%
Hi @guscarreon , @pm-nikhil-vaidya , what is the status here? Can we move forward? Thanks :)
Hi @guscarreon , @pm-nikhil-vaidya , what is the status here? Can we move forward? Thanks :)
Hi @gchicoye I'm waiting for @pm-nikhil-vaidya to review your update so I can re-approve.
Hi @guscarreon , @pm-nikhil-vaidya , what is the status here? Can we move forward? Thanks :)
Hi @gchicoye I'm waiting for @pm-nikhil-vaidya to review your update so I can re-approve.
Hi @pm-nikhil-vaidya , any news?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 9a656bc2169749b042f1c5ab1439135311798144
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:48: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:55: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:64: processImps 88.9%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:107: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:117: MakeRequests 89.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:173: MakeBids 95.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:218: getBidType 91.7%
total: (statements) 90.8%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 60e490de264ac81a84a7bf8a1222b34681342a8b
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:48: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:55: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:64: processImps 88.9%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:107: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:117: MakeRequests 89.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:173: MakeBids 95.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:218: getBidType 91.7%
total: (statements) 90.8%
Apart from endpoint response, PR looks good to me
@guscarreon , does this work for you?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, bc990bdac9ea635dd5c4c9dd4e719be5e97d9f0a
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:43: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:50: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:59: processImps 85.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:105: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:115: MakeRequests 89.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:171: MakeBids 95.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:216: getBidType 91.7%
total: (statements) 90.0%
Hi, any news on this? Thanks!
@gchicoye your adapter looks good. We just sent you an email at the address listed in your YAML file. Can you please reply with 'received' so we can be sure we are able to reach you? Thanks!
@gchicoye your adapter looks good. We just sent you an email at the address listed in your YAML file. Can you please reply with 'received' so we can be sure we are able to reach you? Thanks!
Done :) Thanks!
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, cc882db7ddd5e65ebfe47a852e6f7ce743f577fb
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:43: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:50: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:59: processImps 85.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:105: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:115: MakeRequests 89.3%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:171: MakeBids 95.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:216: getBidType 91.7%
total: (statements) 90.0%
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, 1ac372cd11067ca1ab172fb00b94623ab642f00f
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:43: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:50: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:59: processImps 89.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:99: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:109: MakeRequests 88.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:162: MakeBids 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:207: getBidType 100.0%
total: (statements) 92.9%
hi @bsardo @guscarreon , any news?
@guscarreon you previously approved, can you please review the delta?
Code coverage summary
Note:
- Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
- Coverage summary encompasses all commits leading up to the latest one, b2beef7c8b402d98dcb5539e376a12362fec9d87
nexx360
Refer here for heat map coverage report
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:43: Builder 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:50: getVersion 66.7%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:59: processImps 89.5%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:98: makeReqExt 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:108: MakeRequests 88.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:161: MakeBids 100.0%
github.com/prebid/prebid-server/v3/adapters/nexx360/nexx360.go:206: getBidType 100.0%
total: (statements) 92.9%