prebid-server icon indicating copy to clipboard operation
prebid-server copied to clipboard
verified publisher icon prebid

New Adapter: Rediads

Open rediads opened this issue 10 months ago • 14 comments

This PR adds the Rediads Prebid Server Bid Adapter DOC PR - https://github.com/prebid/prebid.github.io/pull/5907

rediads avatar Feb 21 '25 14:02 rediads

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 3533e8cf0f36dd43973e63c8a6a3c35a8b70f8b4

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:28:	MakeRequests		60.4%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:124:	getMediaTypeForBid	50.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:135:	MakeBids		63.6%
total:									(statements)		61.8%

github-actions[bot] avatar Feb 21 '25 14:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 8ce8ffbf2fd472f34997924e1fb35e5d084ffa00

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:21:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:28:	MakeRequests		60.4%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:124:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:141:	MakeBids		63.6%
total:									(statements)		64.1%

github-actions[bot] avatar Feb 25 '25 15:02 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 049aec7ab5cff69a0da426dee1e1e5b2ee0def9e

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:26:	MakeRequests		75.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:113:	getMediaTypeForBid	83.3%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:128:	MakeBids		88.9%
total:									(statements)		80.0%

github-actions[bot] avatar Feb 26 '25 09:02 github-actions[bot]

@ccorbo , We have implemented/fixed all your review points and added comments to them. Please review the updated code

rediads avatar Feb 26 '25 10:02 rediads

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 49247ad9e75ed32f5add6e3e2d47e395e4c5c7a8

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:26:	MakeRequests		84.1%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:128:	MakeBids		100.0%
total:									(statements)		89.7%

github-actions[bot] avatar Mar 01 '25 08:03 github-actions[bot]

@ccorbo , We have implemented/fixed all your review points and added comments to them. Please review the updated code

symplorpro avatar Mar 01 '25 08:03 symplorpro

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 9c8aef43285f756ed35f5e7b8f7011785b1fbdc3

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:26:	MakeRequests		90.9%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:128:	MakeBids		100.0%
total:									(statements)		94.1%

github-actions[bot] avatar Mar 06 '25 10:03 github-actions[bot]

@ccorbo, We have implemented/fixed all your review points and added comments to them. Please review the updated code

symplorpro avatar Mar 06 '25 10:03 symplorpro

Thanks for the changes.

Validated endpoint image

Sent email to maintainer email addresss to verify. Please respond with received message if you received the email.

ccorbo avatar Mar 06 '25 16:03 ccorbo

Thanks for the changes.

Validated endpoint image

Sent email to maintainer email addresss to verify. Please respond with received message if you received the email.

Replied via maintainer email

rediads avatar Mar 06 '25 17:03 rediads

@ccorbo can you please assign second reviewer?

rediads avatar Mar 10 '25 17:03 rediads

@bsardo Could you please assign another reviewer on this PR - thanks!

ccorbo avatar Mar 17 '25 18:03 ccorbo

@bsardo Could you please assign another reviewer on this PR - thanks!

@bsardo @ccorbo request you to please assign and approve the PR

rediads avatar Mar 26 '25 04:03 rediads

@rediads @guscarreon will give this a look shortly.

bsardo avatar Apr 09 '25 17:04 bsardo

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, da363f679f37dc91eb18b5ae80ea467572f6cf7f

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:19:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:26:	MakeRequests		90.9%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:113:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:128:	MakeBids		100.0%
total:									(statements)		94.1%

github-actions[bot] avatar Apr 27 '25 13:04 github-actions[bot]

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 24223f6fec23578142cd26cfd482b76dd98b5cfc

rediads

Refer here for heat map coverage report

github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:22:	Builder			100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:29:	MakeRequests		91.8%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:121:	getMediaTypeForBid	100.0%
github.com/prebid/prebid-server/v3/adapters/rediads/rediads.go:136:	MakeBids		100.0%
total:									(statements)		94.5%

github-actions[bot] avatar Apr 27 '25 15:04 github-actions[bot]

@ccorbo @bsardo @guscarreon: Requesting you to please help with the reviews. We'll be happy to make any changes/improvements if needed.

symplor-alpha avatar May 28 '25 07:05 symplor-alpha

@guscarreon can you check out their latest changes?

bsardo avatar Jun 13 '25 02:06 bsardo

Hello Team, Can we please get 1 more approval. This is pending from Feb 2025 @guscarreon @ccorbo @bsardo

gamesindian avatar Jun 19 '25 04:06 gamesindian

Taking a look. I'm sorry I couldn't come back to it in such a long time

guscarreon avatar Jun 19 '25 16:06 guscarreon

Taking a look. I'm sorry I couldn't come back to it in such a long time

Hi @guscarreon, just wanted to gently follow up to see if you’ve had a chance to take a look. Let me know if there’s anything we can help with or clarify!

symplor-alpha avatar Jun 28 '25 14:06 symplor-alpha