Gürgün Dayıoğlu

Results 64 comments of Gürgün Dayıoğlu

Seems like there is an issue on node 14? This is the 4th run

I think this issue can be closed. > Try serving a file with fastify-static and wildcard: false. If the file has characters modified by encodeUri then the file will 404....

I don't get this, it works perfectly fine for me when I pass the following: ```js await fastify.register(import("@fastify/static"), { root: [new URL("src/assets/", import.meta.url), new URL("src/models/", import.meta.url)], prefix: "/p/assets", maxAge: process.env.NODE_ENV...

The commit https://github.com/fastify/fastify-static/commit/c70c25dfb6495b8ed4684d04b32b23326c69ba7a has actually fixed this issue by throwing if `list` is used with an array of roots Also, the [README](https://github.com/fastify/fastify-static#list) was updated as well: > Note: > Multi-root...

(Obvious) Note: The header is present when static is combined with compress Note 2: accept-encoding is used more than content-encoding as Vary header

Would you like to send a PR? @jsjoeio

I see in the issue description that onFile doesn’t have corresponding type information Can you please try adding it?

> When calling cleanRequestFiles after the error "request file too large" happens I haven't reproduced it yet, but isn't the requestFileTooLarge error thrown *while* a file is being consumed and...

Can you please share more details? The files aren’t saved before they are fully consumed, so there should be no reason to clean up anything https://github.com/fastify/fastify-multipart/blob/8e4b5e50dcfbca51e5897d159f37c118515ee7a3/index.js#L411-L422 I don’t think there...