Gürgün Dayıoğlu

Results 64 comments of Gürgün Dayıoğlu

I know this is probably not the form of simplification you’re talking about, but there was some talk on removing the non-async, callback-based API for handlers. I think that would...

> > I know this is probably not the form of simplification you’re talking about, but there was some talk on removing the non-async, callback-based API for handlers. > >...

Not sure if it's doable but we could maybe do: - human creates a prerelease - action makes the PR - human merges - action makes full release on GH...

Things seem fine on MacOS, could be dependent on your environment or maybe Linux, but CI looks OK too...

Can you see this? We recently landed it and Set performed a little better, it might already be using something like that under-the-hood: https://github.com/fastify/fastify/pull/5419

I agree with releasing v5, _or at least a prerelease_, ASAP at this point @mcollina told me he'd get to it (the full release) in July But by doing that...

Should I create a new PR for https://github.com/fastify/fastify/pull/5419?

Okay, just letting you know that if you restore https://github.com/fastify/fastify/pull/5419, some tests will _not_ pass because main merged https://github.com/fastify/fastify/pull/5439 and next needs https://github.com/fastify/fastify/pull/5444 to merge for those tests to pass,...

~It's fine, we should merge https://github.com/fastify/fastify/pull/5444 and it should be good~ Edit: ok merge handled those

In fact on MacOS `test/close-pipelining.test.js` is flaky in all versions https://github.com/fastify/fastify/actions/runs/8798010153/job/24144255184#step:5:1174