Gürgün Dayıoğlu
Gürgün Dayıoğlu
> Then this comment is completely wrong It might depend on the configuration, which is why I asked for more information... But don't take my word: We consume the stream...
There could indeed be a getCookie method
Oof, that's correct, good catch A PR that downgrades it is welcome
When Fastify v5 is released (probably by the end of this year)
@Eomm is more familiar than me and might be able to help faster, but I’ll try to take a look
> The regex is both more correct and faster (https://esbench.com/bench/6532596e7ff73700a4debb6a). Examples: previous regex recognized "01.01.01.01" or "1.1.000.1" as correct ipv4 regex, but those aren't valid as per https://datatracker.ietf.org/doc/html/rfc5954#section-4.1. >> Func...
Seems relevant https://github.com/colinhacks/zod/pull/3413
Okay, so 3 is spec compliant and faster than current? Seems like an easy win ~Can you make that the PR?~ (It already is, can you resolve conflicts?) We can...
I like it! What do others think? Definitely SemVer major but note that it'll be faster and **still** spec compliant (RFC [3968](https://datatracker.ietf.org/doc/html/rfc3986#section-7.4)) @fastify/libraries, @mcollina
CI error not related I believe