fast-json-stringify icon indicating copy to clipboard operation
fast-json-stringify copied to clipboard

fix: escape single quote when building error message for required property

Open tomastauer opened this issue 1 year ago • 2 comments

closes https://github.com/fastify/fast-json-stringify/issues/715

Checklist

tomastauer avatar Apr 24 '24 07:04 tomastauer

@ivan-tymoshenko could you please try to restart the CI? Seems the fail is not related to the changes in this PR

tomastauer avatar Apr 26 '24 12:04 tomastauer

Seems like there is an issue on node 14?

This is the 4th run

gurgunday avatar Apr 26 '24 18:04 gurgunday

Yes. macos-latest gha env is now arm based. There is no Node v14 for arm. It's failing everywhere.

Either we test on older Mac envs or we just ignore that combo.

mcollina avatar Apr 28 '24 09:04 mcollina

Lets ignore it.

Uzlopak avatar Apr 28 '24 10:04 Uzlopak