Gary Thomas

Results 15 comments of Gary Thomas
trafficstars

Hi, just an update on this - we have a [fork](https://github.com/reactstrap/reactstrap/compare/master...gthomas-appfolio:master) that we plan to PR back here to reactstrap's [bootstrap5 branch](https://github.com/reactstrap/reactstrap/tree/bootstrap5) after completing Bootstrap 5.0 beta 1 compatibility. Hopefully...

Hi @kyletsang In general I'd agree with you, but the prop and component differences between RB and reactstrap means many projects can't just switch without extensive code changes. My co....

Hi all, I've created a PR to the bootstrap5 branch, hopefully the rebasing, etc came through okay. https://github.com/reactstrap/reactstrap/pull/2102 This adds support up to Bootstrap v5.0.0 beta 2 as thoroughly as...

Hi @kyletsang et al, now that bootstrap5 branch is updated (thanks all!) can you do a prerelease version to npm? Will it be v9.0.0-beta2, etc?

Secondly, would you all be up for a PR to move docs to [storybook](https://storybook.js.org)? We have experience with it and would be happy to look at this.

Thanks @chelaru-artur , do you think this could be a PR to add this feature? I'll try out this out too, thanks.

Hi @moyuan, thanks we should do that, there were just some styling changes (border, etc) that we’d need to rework to be themeable. Current open PR is tracked here: #461

https://github.com/appfolio/react-gears/pull/610

Thanks for the catch 👍

Also looks like using `reorderable` prop causes any inputs being typed to lose focus when typed in, looks like due to re-render of reorderable list. Looks due to this: https://github.com/clauderic/react-sortable-hoc/issues/120#issuecomment-274082422