react-gears icon indicating copy to clipboard operation
react-gears copied to clipboard

Considering shift from `react-select-plus` to `react-select v2`

Open moyuanhuang opened this issue 6 years ago • 4 comments
trafficstars

This issue is based on the assumption that we're only using react-select-plus instead of react-select. Correct me if I'm wrong, and I'll close the issue :)

The purpose of using react-select-plus was to support option groups in the dropdown, a feature that react-select didn't have.

Now that the v2 version of react-select added support this feature (I think they just back merged the code from react-select-plus), react-select-plus is not longer 'actively maintained'. We should consider changing the package from react-select-plus to react-select for the sake of compatibility. It's good also because react-select v2 now support a lot of new features that could probably enable us to do more interesting things! https://react-select.com/home

moyuanhuang avatar Dec 17 '18 17:12 moyuanhuang

Hi @moyuan, thanks we should do that, there were just some styling changes (border, etc) that we’d need to rework to be themeable.
Current open PR is tracked here: #461

gthomas-appfolio avatar Dec 17 '18 17:12 gthomas-appfolio

@phwebi Do we have any plans on this? I've got a working branch

moyuanhuang avatar Jan 29 '20 18:01 moyuanhuang

@moyuanhuang I saw this issue when I was browsing yesterday and I think it'd be nice to do! Feel free to make a PR if your branch is up to date and I can help review 😄

phwebi avatar Jan 29 '20 21:01 phwebi