react-gears icon indicating copy to clipboard operation
react-gears copied to clipboard

Inline prop in FormRow has no effect

Open haobo-chen opened this issue 7 years ago • 2 comments

inline prop in FormRow is dereferenced but not used or passed to any child component

haobo-chen avatar Jun 08 '18 00:06 haobo-chen

Thanks for the catch 👍

gthomas-appfolio avatar Jun 08 '18 00:06 gthomas-appfolio

I noted this in a recent change to FormRow (https://github.com/appfolio/react-gears/pull/426):

// Note:  `inline` has no effect at the moment.  In reactstrap 5 and later, this property appears
// to be relevant for the <FormGroup>, though.  As such, we may be able to simplify this class with
// the built-in support of inline forms in newer versions of reactstrap.

joshuasbates avatar Jun 29 '18 18:06 joshuasbates