Gregory Terzian

Results 107 issues of Gregory Terzian

Fix #453 *** ### :boom: Error: 500 Internal Server Error :boom: ### [PR Preview](https://github.com/tobie/pr-preview#pr-preview) failed to build. _(Last tried on Jan 15, 2021, 7:33 AM UTC)_. More PR Preview relies...

do not merge yet

FIX https://github.com/massalabs/massa/issues/3140 * [ ] document all added functions * [ ] try in sandbox /simulation/labnet * [ ] unit tests on the added/changed features * [ ] make tests...

api
breaking

Since we are currently often working with a different target, it might make sense to change the CI settings for a full run in those cases as well.

ci

1. Have you considered merging the two factory threads? I think having two could lead to weird behavior under load(since the timeout doesn't guarantee wake-up on time). 2. Why don't...

When building the crate with the `testing` feature enabled, I get the below error, even though the method is actually [implemented](https://github.com/massalabs/massa/blob/a56bc624fc21464a1137b650065dd6dbd9f8cb0c/massa-pos-worker/src/controller.rs#L157) with that feature flag... ``` error[E0046]: not all trait...

test

Ignoring the tests in https://github.com/massalabs/massa/pull/2984 that seems to be failing intermittently at https://github.com/massalabs/massa/actions/runs/3044303046/jobs/4904742131 That makes for a total of three ignored in the protocol worker suite.

`wait_command` does a blocking `recv_timeout` on a `std::sync::mpsc::Receiver`, which blocks the current thread. In a single threaded async context(the [default](https://docs.rs/tokio/latest/tokio/attr.test.html) for the tokio tests), this means it blocks the thread...

See those currently ignored in https://github.com/massalabs/massa/tree/release_testnet_14

* [ ] document all added functions * [ ] try in sandbox /simulation/labnet * [ ] unit tests on the added/changed features * [ ] make tests compile *...

* [ ] document all added functions * [ ] try in sandbox /simulation/labnet * [ ] unit tests on the added/changed features * [ ] make tests compile *...