Replace gas price with fee, or remove it

[gterzian]

• [ ] document all added functions
• [ ] try in sandbox /simulation/labnet
• [ ] unit tests on the added/changed features
  • [ ] make tests compile
  • [ ] make tests pass
• [ ] add logs allowing easy debugging in case the changes caused problems
• [ ] if the API has changed, update the API specification

[gterzian]

@damip Thanks for the review, it is ready for another round. Still wondering about https://github.com/massalabs/massa/pull/3173#discussion_r1001044886

[gterzian]

Tested this with the simulator(using the branch of https://github.com/massalabs/massa-sc-runtime/pull/156 for the runtime). The charge.py script ran without problems. cc @damip @aoudiamoncef

[gterzian]

@aoudiamoncef Could you please take a look at the changes to openrpc.json in the light of https://github.com/massalabs/massa-sc-runtime/pull/156#issuecomment-1299932922?

[gterzian]

@damip @aoudiamoncef Should we try to merge both this one and https://github.com/massalabs/massa-sc-runtime/pull/156 ?

[damip]

@gterzian there are some unadressed comments in this PR. Can you address them all ?

[gterzian]

there are some unadressed comments in this PR. Can you address them all ?

Yes, thanks for pointing those out... @damip

[gterzian]

@damip Note that the AsyncMessageId changes change the behavior of the take_batch_to_execute method of AsyncPool, see this change.

Is this intended?

[gterzian]

Ok I think we can review as a package this PR, as well as:

• https://github.com/massalabs/massa-as-sdk/pull/30
• https://github.com/massalabs/massa-sc-runtime/pull/156

@damip @aoudiamoncef

[gterzian]

Ok the runtime dependency now points to the testnet_17 branch of the runtime

[gterzian]

The failing boostrap server test has been fixed, and it's a bit suspicious that it passes/fails based on the ordering of the operations, which points to some sort of timing sensitivity, and it may in fact still fail intermittently. It would be good to find out exactly what is going on here. I've field https://github.com/massalabs/massa/issues/3227. cc @massalabs/core-team

[gterzian]

If you tested it in local with the others repository. Ok to merge it.

@AurelienFT ran charge.py with the simulator on it without problems...

[AurelienFT]

@AurelienFT ran charge.py with the simulator on it without problems...

I think you can fix conflicts and merge it so.

[gterzian]

tests::scenarios::test_bootstrap_server starting to fail again after the rebase...

Actually it's intermittent, I've opened https://github.com/massalabs/massa/issues/3241

Should we merge this one? @AurelienFT

[Eitu33]

Let's merge this imho, I'll take care of the bootstrap test https://github.com/massalabs/massa/issues/3241#issuecomment-1326213822