massa icon indicating copy to clipboard operation
massa copied to clipboard

Remove gas price

Open gterzian opened this issue 2 years ago • 5 comments

FIX https://github.com/massalabs/massa/issues/3140

  • [ ] document all added functions
  • [ ] try in sandbox /simulation/labnet
  • [ ] unit tests on the added/changed features
    • [ ] make tests compile
    • [ ] make tests pass
  • [ ] add logs allowing easy debugging in case the changes caused problems
  • [ ] if the API has changed, update the API specification

gterzian avatar Oct 10 '22 09:10 gterzian

@massalabs/core-team @damip Still have to fix a few tests that are failing(see those currently ignored), sorry I still cannot access discord...

gterzian avatar Oct 17 '22 07:10 gterzian

@damip Thanks for the clarification! So the fee in all cases would come from that found on the operation, except for the send_message ABI where we'd have to add it as a call parameter?

gterzian avatar Oct 19 '22 09:10 gterzian

@damip Thanks for the clarification! So the fee in all cases would come from that found on the operation, except for the send_message ABI where we'd have to add it as a call parameter?

Yes exactly

damip avatar Oct 19 '22 09:10 damip

@gterzian I made a mistake in one of my comments above: the first criterion of the async pool sorting should not be msg.fee but rev(Ratio(msg.fee, max(msg.max_gas,1)))

damip avatar Oct 19 '22 09:10 damip

continuing over at https://github.com/massalabs/massa/pull/3173

gterzian avatar Oct 20 '22 09:10 gterzian

Closing in favor of https://github.com/massalabs/massa/pull/3173

gterzian avatar Oct 31 '22 07:10 gterzian