Gabriel Selzer
Gabriel Selzer
I'm not sure that I'll have the chance to look at the code until Tuesday or so @kephale, but this looks really awesome - thanks for implementing it! One quick...
> I have some concerns about all the consoles/repls getting confused. I was actually a little worried about making this icon so similar to the napari-console icon. Yeah, I thought...
This was a *long* time coming @ctrueden @kephale, however I've just rebased this PR on top of the latest `main` and resolved the WIP, getting tests to pass. I'm embarrased...
TODO: Bump recommended scijava-search version to include scijava/scijava-search#30
While this works, it'd be cool to get new versions of imagej-ops and scijava-search to pin here, so that we can get imagej/imagej-ops#651 and scijava/scijava-search#30 pinned as "recommended minimums". Pinging...
After talking with @hinerm and @ctrueden, we might want to push a minimum imagej version as well - I think 2.10.0?
I added on a commit here to recommend ImageJ2/Fiji 2.10.0, so this PR will also close #289
Yeah, this is a pesky bug. I'm looking forward to fixing it!
This PR now loads all icons stored as resources within jars. It does not yet load icons from the web, mostly due to performance implications. Filed #296 to track that...
For example, the user icons from `SearchResult`s pulled from forum.image.sc