Gabriel Selzer
Gabriel Selzer
I finally got the chance to read about `pbr` and it does seem nice, although it might be overkill. I would not be opposed to using it!
@ctrueden by and large that seems nice. One remaining issue is that `MANIFEST.in` includes `graft test`, which is wrong since we renamed the test folder to `tests`.
@ctrueden is this [done](https://github.com/imagej/pyimagej/blob/master/doc/Troubleshooting.md#could-not-transfer-artifact)?
> I think our four choices are: > > 1. Invent some ImageJ-specific dtypes; or > > 2. Reuse the numpy dtypes; or > > 3. Use plain Python types...
@ctrueden I don't think I ever really tried, sorry.
@ctrueden I only have time to quickly glance over this, but we can probably add all this functionality with a couple of `OpField`s. I will add it to the TODO...
@imagejan https://github.com/scijava/incubator/pull/36 😉
@ctrueden I reorganized the math within `DefaultASCII.java` and replaced the `assertTrue` statements with `assertEquals` (or `assertNotEquals`). Let me know if there is anything else that you see. Thanks!
@ctrueden after pushing the changes that you suggested I got test failures. This is due to the fact that we cannot simply use `tmp.div(span)` get the normalized value to pull...
@ctrueden I took your advice and leaned on some helper `Op`s to simplify the code. Note that we convert to `DoubleType` to prevent rounding errors (correct me if I am...