napari-imagej icon indicating copy to clipboard operation
napari-imagej copied to clipboard

Add recommended_versions

Open gselzer opened this issue 1 year ago • 5 comments

This enables us to suggest users upgrade their versions without forcing them to do so.

In this way, we allow users to upgrade their napari-imagej package without updating their ImageJ, but also being able to "rely" on newer Java component versions.

gselzer avatar Jun 06 '23 16:06 gselzer

TODO: Bump recommended scijava-search version to include scijava/scijava-search#30

gselzer avatar Jun 16 '23 18:06 gselzer

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.11% :tada:

Comparison is base (75cedb6) 88.51% compared to head (5dd4fb4) 88.62%. Report is 2 commits behind head on main.

:exclamation: Current head 5dd4fb4 differs from pull request most recent head 8a71ad8. Consider uploading reports for the commit 8a71ad8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #264      +/-   ##
==========================================
+ Coverage   88.51%   88.62%   +0.11%     
==========================================
  Files          53       53              
  Lines        4912     4942      +30     
==========================================
+ Hits         4348     4380      +32     
+ Misses        564      562       -2     
Files Changed Coverage Δ
src/napari_imagej/java.py 94.31% <100.00%> (+0.18%) :arrow_up:
tests/test_java.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Jul 20 '23 16:07 codecov-commenter

While this works, it'd be cool to get new versions of imagej-ops and scijava-search to pin here, so that we can get imagej/imagej-ops#651 and scijava/scijava-search#30 pinned as "recommended minimums".

Pinging @hinerm.

gselzer avatar Jul 20 '23 16:07 gselzer

After talking with @hinerm and @ctrueden, we might want to push a minimum imagej version as well - I think 2.10.0?

gselzer avatar Jul 27 '23 15:07 gselzer

I added on a commit here to recommend ImageJ2/Fiji 2.10.0, so this PR will also close #289

gselzer avatar Aug 01 '23 21:08 gselzer