Gabriel Selzer
Gabriel Selzer
@ctrueden I rebased this over `master`. It seems to me like it is ready to merge. Thoughts?
I generally agree with what has been discussed. @MarcelWiedenmann said: > Given we would agree on using the output's cursor, then input and output would need to be aligned, right?...
@ctrueden I found test commit that was for some reason not pushed. The test passes and is sound, however it introduces a test-scope dependency on [scijava-io-http](https://github.com/scijava/scijava-io-http) that I am not...
@ctr26 can you be more specific in which Ops have the issue? I am only seeing this issue in [`PartialDerivativesRAI`](https://github.com/imagej/imagej-ops/blob/b120cd7dea3433000916a3a58a0daf78dd8ff895/src/main/java/net/imagej/ops/filter/derivative/PartialDerivativesRAI.java#L75). I am not seeing this issue in any of the...
@ctr26 that is failing for other reasons. Check the agreement of the arguments you are passing with the parameters of the Op ([forum.image.sc](https://forum.image.sc/) is the place to discuss this). If...
Half of the edge artifacts were fixed by adding the logic present in the plugins that differs output between `IntegerType` images and non-`IntegerType` images. Honestly I have not figured out...
That is a good point @bnorthan, I had little understanding/awarenesss of the convolve Ops, so I didn't even think to use them. At this point I have `DefaultSharpen` providing the...
@bnorthan both Ops now pass most of the work on to helper Ops. Using some `System.nanotime`s in the I found that the Op and the plugin had comparable completion times....
@bnorthan yes, I was also thinking about that as well, however I did not do it because I had no idea where we would house such an Op, since it...
@bnorthan I think the only thing preventing us from using `DefaultMeanFilter` for `DefaultSmooth` is [this line here](https://github.com/imagej/imagej-ops/blob/fde412ae787b622e4513e4f2e720d61497e682f5/src/main/java/net/imagej/ops/filter/smooth/DefaultSmooth.java#L141). If you see a way around this I would be happy to use...