Greg Magolan
Greg Magolan
I haven't seen the `bazel run` case handled in other ecosystems. Cases I've seen, users are keying off of `BAZEL_TEST` for test targets or setting explicit envs such as `BAZEL`...
> Bazel itself sets `BAZEL_TEST` though, not rules_js? Should we avoid setting anything without a `JS` pre/suffix? How about `RULES_JS` or `JS_TEST|RUN|BUILD` etc? Yes, tho `BAZEL_TEST` is only set when...
> I'm just nitpicking this because every added variable has the potential to collide with something the user already set, and shorter is more likely. I do check if it...
Have a repro here, https://github.com/aspect-build/rules_js/pull/1063. Working on a fix.
Hmm. It is a tricky one and more than an hour of work. I think this one will have to wait until next week when either @jbedard or I have...
Notes from repro in #1063... In `/private/var/tmp/_bazel_greg/7aed427a991d86f99332ab79b9b11780/external/npm/repositories.bzl` the generated `npm_import` for the problematic `@isaacs/[email protected]` package looks like this, ``` npm_import( name = "npm__at_isaacs_cliui__registry.npmjs.org_at_isaacs_cliui_8.0.2", root_package = "", link_workspace = "", link_packages...
The other key observation is that this issue ONLY happens when the package name in the pnpm lock file starts with `registry.npmjs.org/` such as ``` registry.npmjs.org/@isaacs/[email protected]: resolution: {integrity: sha512-O8jcjabXaleOG9DQ0+ARXWZBTfnP4WNAqzuiJK7ll44AmxGKv/J2M4TPjxjY3znBCfvBXFzucm1twdyFybFqEA==, registry:...
@devversion This is a potential work-around for the material repository: https://github.com/angular/material.angular.io/pull/1208/files
Essentially, yes. The logic breaks for the aliases somewhere along the way with the `registry.npmjs.org/` prefixed versions. I started down the path of fixing it but it was more work...