Greg Magolan

Results 204 comments of Greg Magolan

Resolved with `update_pnpm_lock` feature in `npm_translate_lock`

Thanks for all the debugging @joac I did add land an example of a package that calls node-gyp recently. https://github.com/aspect-build/rules_js/pull/586#issuecomment-1363298639 I'll catch up this thread next week as its a...

Setting this as low priority since no one is currently asking for it and it is a medium to large task to get right complete with test cases

@meteorcloudy This commit would be useful to cherry pick into 6.0 if possible https://github.com/bazelbuild/bazel/commit/4959d34e844714b793b2c6fa05016a9a6eaa7044. Fixes a minor annoyance in downstream rule sets. 🙏

@meteorcloudy I narrowed down another interesting regression in Bazel 6: https://github.com/bazelbuild/bazel/issues/16978. I tested as far back as rc1 and it was there in that release.

@marsh73 I gave the CRA example an upgrade recently: https://github.com/aspect-build/bazel-examples/tree/main/react-cra. A added jest test targets, eslint targets, separate ts_project transpilation targets for application code and specs. The react-scripts "build" target...

I'll make another PR to re-organize the code so it looks more like it would in a monorepo with the react-scripts build target not in the root BUILD file

This should all be working no with the latest rules_js release. [react-cra](https://github.com/aspect-build/bazel-examples/tree/main/react-cra) example has it all wired up: https://github.com/aspect-build/bazel-examples/blob/1f21299f0eaf526fc9ed2378f7beb9e2b0b501a2/react-cra/package.json#L28 ``` "eslintConfig": { "extends": [ "react-app", "react-app/jest" ] }, ``` and...

This should no longer be an issue with Bazel 6 since `@local_config_platform` now exports `constraints.bzl` and bazel-lib uses: ``` bzl_library( name = "local_config_platform_constraints", srcs = ["@local_config_platform//:constraints.bzl"], visibility = ["//visibility:public"], )...

@lummax There have been quite a few changes to the lifecycle hooks code since this was reported. Is this still an issue for you? Windows support is low priority for...