Greg Magolan
Greg Magolan
**What type of PR is this?** Bug fix **What does this PR do? Why is it needed?** The DefaultInfo provided by the `bindata` rule doesn't put its output in runfiles....
With https://github.com/aspect-build/rules_js/pull/283 landed, rules_js will now use the [ctx.actions.declare_symlink](https://docs.bazel.build/versions/main/skylark/lib/actions.html#declare_symlink) API to create all of the symlinks in the symlinks node_modules tree if the `--experimental_allow_unresolved_symlinks` flag is set. This feature is...
The relevent code in node is in resolve.js where there is a realPathSync call https://github.com/nodejs/node/blob/4c5b96b376aa778cbe651362c29a26e0d4c32ccd/lib/internal/modules/esm/resolve.js#L310 This realPathSycn call does not get the fs monkey paches while the cjs require loader's...
See https://github.com/aspect-build/rules_js/issues/374#issuecomment-1209729290 for more context. TL;DR is that pnpm default `hoist-pattern` of `["*"]` (https://pnpm.io/npmrc#hoist-pattern) creates a `node_modules/.pnpm/node_modules` folder that allows packages within the virtual store to resolve these hoisted packages...
This is causing test failures if srcs are not copied to bin As seen here https://github.com/aspect-build/bazel-examples/blob/a76be559cd89a645308ff0f2e6a02a82c780010f/angular/defs.bzl#L133 and here https://github.com/aspect-build/bazel-examples/blob/a76be559cd89a645308ff0f2e6a02a82c780010f/angular/defs.bzl#L195
Tested this in https://github.com/aspect-build/rules_js/pull/367 and it is almost supported with existing constructs except that transitive deps of first-party workspace links are not picked up because the information is split across...
This is nearly supported from existing constructs except that transitive deps of first-party workspace links are not picked up because the information is split across lock files. Should be relatively...
https://github.com/aspect-build/rules_js/pull/89/files#r867406427
Could also bundle with rules_esbuild or rules_rollup but I figure the webpack route is going to be the most common and it also gives you a devserver