Greg Magolan comments

Results 248 comments of


                                            Greg Magolan

[Bug]: On Windows use `pushd` instead of `cd`

Thanks for the suggestion

[FR]: Separate toolchain for for C++ headers

Not stale

[FR]: Separate toolchain for for C++ headers

I'm going to be looking at this this week to make this fix before rules_js 2.0 final so if it needs to be breaking for some use cases we can...

[FR]: Separate toolchain for for C++ headers

Fix landed and released with https://github.com/bazelbuild/rules_nodejs/releases/tag/v6.2.0

What about undeclared dynamic dependencies?

I don't think using `optionalDependencies` approach will work for the `tsickle` case. npm and yarn always attempt to install `optionalDependencies` and if the install fails then it is ignored. Packages...

[FR]: support multiple targets, in line with cli api

Thanks for the suggestion. If it is supported by the CLI then we shouldn't prevent it with the rule API. Added this to the 1.0 milestone for this rule set.

[FR]: --loader option

Likely just need an example of how to use `--loader`

[FR]: Add support for assetName esbuild API

Hmmm. Perhaps the correct API should be `out_dirs` to be able to specify multiple expected output dirs. This is what the API we went with in [js_run_binary](https://docs.aspect.build/rules/aspect_rules_js/docs/js_run_binary#out_dirs). This could be...

[FR]: Default cacheDirectory to TEST_TMPDIR

More context on Bazel Slack: https://bazelbuild.slack.com/archives/C04281DTLH0/p1706234301711269

jest runtime slower then non-bazel

Measure 3 things: - non-bazel - rules_js with patches and no sandbox - rules_nodejs with patches and no sandbox