Ulrich Pogson

Results 91 comments of Ulrich Pogson

Looks good. Though `global $post;` should not be needed.

The PR #149 is only solving the problem temporarily. What about adding a filter so that it can be defined according to the environment?

I have have tried to create a version where a filter is used: https://github.com/grappler/vip-scanner/commit/27db1a3dc995d54784087e0eb39ab398879e3cc0 I am getting an error with my current code. `Parse error: syntax error, unexpected '(', expecting...

At the first glance I can't see an issue with with code with `_n`. As for the text domain. The text domain must the same as the theme name. So...

Ah, yes we also need to allow "wordpress" in urls like example.com/wordpress/my-super-wordpress-theme.

What about `/\$wp_customize->add_setting\((.*\)(?=;))/Us`?

We can only catch the bigger offenders. I don't fully understand what you mean with tokenization? I wonder if we could build on top of [WordPress-Coding-Standards](https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards)

~~Please can you explain why you can just the normal tags?~~~ Edit: I see now that the reason is from https://github.com/erusev/parsedown/issues/469 We are working on a new update of the...

Sorry, I came across a bit harsh in my previous comment as I did not initially realize it was a false positive. As we are planning of releasing a complete...