Ulrich Pogson

Results 146 comments of Ulrich Pogson

@joyously You should be using `add_theme_support( 'title-tag' ); or `the_archive_title` instead. > why have the function? Like everything it was introduced when there was a need and now we have...

> `the_archive_title` doesn't have all the same filters on it as `wp_title`. You can always use the filter `get_the_archive_title` to make changes. `wp_title()` should only be used to add the...

Totally agree with the additional sniffs. We want to check all of the URLs added in theme to check that there are no spam links. Maybe we need to rename...

Making a note that @dmtrmrv is working a sniff.

Related Theme Check issue https://github.com/WordPress/theme-check/issues/119 I think these would make sense. Just to clarify that these will be warning and not errors. A PR can be made once we have...

`WordPress.Theme.DiscouragedFunctions` sounds good. I am not fully sure what I was thinking. Maybe to prevent merge conflicts or that I was high on the parameter abstract sniff.

> Isnt using home_url() instead of site_url() required? No, but we can always run the sniff on existing themes once is made to see if we can find any use...

@joyously Yes, by checking the parameter/option name that is being modified.

I think this would be good. I don't think I would go with JSLint or JSHint as they do not only check for syntax but for coding standards too. Additional...

> Can this be added in this fork of code sniffer, or should we be patient and wait for the official release from the squizilabs guys? We have a few...