Ulrich Pogson

Results 146 comments of Ulrich Pogson

> I used it for a little while, but it has to be manually configured to work properly so I kinda... delayed it xD Even a blog post with a...

This falls under > Avoid hard coding to modify content. Instead, use function parameters, filters and action hooks where appropriate. This should be an error. By using a hardcoded a...

> A theme names its menu locations, not the user. You are right but we are not talking about the location but the menu name. These are the two parameter...

I would go with > Only admin pages within the Themes submenu and of those, not the known core ones (themes, customizer and its variants, widgets, menus, theme-editor). I agree...

Created a PR upstream for this https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/pull/1364

If the check is failing which it was in the Theme Check it should have been Required instead of a Warning so an Error is OK.

@ryelle Thank you for your suggestions. We can alway mark certain functions of warnings that the reviewer should manually check. Would you have some examples of JS that could be...

> If the object is a variable, how would the sniff be able to tell? If the variable is being defined in the same file then we could look for...

@kkoppenhaver That would be great! No one is working on this yet.

Some of the sniffs in WPCS are not separated correctly so that is why I opened an issue to discuss it https://github.com/WordPress-Coding-Standards/WordPress-Coding-Standards/issues/582